Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundent function latest_constants_with_overrides #1963

Closed
wants to merge 1 commit into from
Closed

chore: remove redundent function latest_constants_with_overrides #1963

wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Nov 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware mentioned this pull request Nov 11, 2024
Merged
@ArniStarkware ArniStarkware marked this pull request as ready for review November 11, 2024 18:35
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (e3165c4) to head (d630be9).
Report is 331 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   40.10%   44.67%   +4.56%     
==========================================
  Files          26      196     +170     
  Lines        1895    23558   +21663     
  Branches     1895    23558   +21663     
==========================================
+ Hits          760    10524    +9764     
- Misses       1100    12557   +11457     
- Partials       35      477     +442

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware mentioned this pull request Nov 11, 2024
Closed
@ArniStarkware ArniStarkware changed the base branch from arni/blockifier/versioned-constants/define_correct_default to graphite-base/1963 November 12, 2024 07:53
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/blockifier/versioned-constants/remove-latest-with-overrides branch from b85499f to 4fa0280 Compare November 12, 2024 07:54
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware changed the base branch from graphite-base/1963 to main November 12, 2024 07:54
@ArniStarkware ArniStarkware force-pushed the arni/blockifier/versioned-constants/remove-latest-with-overrides branch from 4fa0280 to d630be9 Compare November 12, 2024 07:55
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yael-Starkware
Yael-Starkware approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@ArniStarkware
Copy link
Contributor Author

Covered by #1946

@ArniStarkware ArniStarkware deleted the arni/blockifier/versioned-constants/remove-latest-with-overrides branch November 12, 2024 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yael-Starkware Yael-Starkware Yael-Starkware approved these changes

@yair-starkware yair-starkware Awaiting requested review from yair-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @Yael-Starkware